fix: use correct npm-scope/npm-package config keys for cargo-dist#9
fix: use correct npm-scope/npm-package config keys for cargo-dist#9
Conversation
🦋 Changeset detectedLatest commit: afbeb70 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where the npm package was being published with an incorrect name due to misconfigured keys in the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request corrects the cargo-dist configuration in dist-workspace.toml by renaming the scope and package keys to npm-scope and npm-package. This is the correct fix for ensuring the npm package is published with the intended scoped name @googleworkspace/cli. The change is straightforward and resolves the described issue.
Note: Security Review has been skipped due to the limited scope of the PR.
…ogleworkspace#9) * fix: use correct npm-scope/npm-package config keys for cargo-dist * chore: add changeset * docs: add changeset instructions to AGENTS.md
1 participant
Problem
The npm package was being published as
gwsinstead of@googleworkspace/clibecausedist-workspace.tomlused the wrong config keys:scope→ should benpm-scopepackage→ should benpm-packageCargo-dist silently ignored the unrecognized keys and fell back to the Cargo package name.
Fix
Renamed to the correct keys per the official docs:
The npm package will now be published as
@googleworkspace/cli.